Reduce chunk size from 32MB to 256KB for proper TCP backpressure#103
Merged
Reduce chunk size from 32MB to 256KB for proper TCP backpressure#103
Conversation
The 32MB chunk size was causing memory bloat because Hyper buffers received data while waiting to write to the TCP socket. Changes: - CHUNK_SIZE: 32MB -> 8MB - CHANNEL_CAPACITY: constant (2) for ~16MB max in flight - Simplified comments to not hardcode capacity values - Updated test to use 20MB file (3 chunks with new size) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
eebf4ab to
22cddd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes high memory usage (2GB+) when serving large ISO files.
Root cause: 32MB chunks are too large for TCP. Hyper buffers received data while waiting to write to socket, causing memory to accumulate.
Fix:
CHUNK_SIZE: 32MB → 8MBCHANNEL_CAPACITY: 2 (~16MB max in flight)Expected results
Test plan
🤖 Generated with Claude Code