Defer validatation failures raised during balancing#514
Draft
mmontin wants to merge 3 commits intomm/effectfulfrom
Draft
Defer validatation failures raised during balancing#514mmontin wants to merge 3 commits intomm/effectfulfrom
mmontin wants to merge 3 commits intomm/effectfulfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
TxSkeloption to defer validation failures occurring during balancing.As a consequence, the balancing succeeds even when running the script to assign execution units fails, and thus the balanced
TxSkelcan be traced.As a downside, this drastically decreases performances (as scripts are run several more times, even if we know they fail) and thus is only made available as an option, disabled by default.
Fixes #435
Fixes #494
Fixes #500
Fixes #503