Add explicit check for importing remote Bootstrap JS #848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G'day Paul! Hope you've been well since try! Swift this year! 👋
I'm in the middle of migrating my blog away from WordPress (at long long last) and I'm looking at redoing the whole lot on Ignite! The documentation and the examples have made it incredibly easy to get started. 🤩
That being said, in typical developer fashion, I'd like to be able to start with an absolutely clean slate so I can specify my own CSS and JS from scratch. I was looking at disabling Bootstrap entirely, and I noticed that even if I set
useDefaultBootstrapURLsto.none, it would still remotely import the Bootstrap JS file, which might not be the intended logic here.Here's a quick PR for adding an explicit check, which I've confirmed already works correctly.
Meanwhile, I'm still looking into if there's already a way to do this, but I'd also like to disable
ignite-core.min.cssso I can implement my own CSS reset logic. I'll look into that for a separate PR.Hope this helps! Thanks so much!