Skip to content

unified logging #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
The-Wolfson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

unified logging #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ShipShape/Activities/ASCLogView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@ import SwiftUI

struct ASCLogView: View {
@Environment(ASCClient.self) var client
@Logger var logger

var body: some View {
List {
Section("Click to print to Xcode log") {
ForEach(client.logEntries) { entry in
Button(entry.url) {
print(entry.response)
logger.debug("\(entry.response)")
}
.buttonStyle(.plain)
}
Expand Down
2 changes: 1 addition & 1 deletion ShipShape/Client/ASCClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class ASCClient {
request.setValue("application/json", forHTTPHeaderField: "Content-Type")

let data = try JSONEncoder().encode(content)
print(String(decoding: data, as: UTF8.self))
logger.info("\(String(decoding: data, as: UTF8.self))")

let (_, response) = try await session.data(for: request, delegate: nil)

Expand Down
2 changes: 1 addition & 1 deletion ShipShape/Utilities/Logger.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//

import Foundation
import OSLog
import os

@propertyWrapper
struct Logger {
Expand Down