Open
Conversation
scarmuega
reviewed
Sep 30, 2025
crates/tx3-lang/src/tx3.pest
Outdated
Comment on lines
394
to
395
| cardano_payment_part = { "payment_part" ~ "(" ~ data_expr ~ ")" } | ||
| cardano_staking_part = { "staking_part" ~ "(" ~ data_expr ~ ")" } |
Contributor
There was a problem hiding this comment.
rename to cardano_address_payment_part and cardano_address_staking_part
scarmuega
reviewed
Sep 30, 2025
crates/tx3-lang/src/cardano.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)] | ||
| pub struct CardanoPaymentPart { |
Contributor
There was a problem hiding this comment.
rename to AddressPaymentPart
scarmuega
reviewed
Sep 30, 2025
crates/tx3-lang/src/cardano.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)] | ||
| pub struct CardanoStakingPart { |
Contributor
There was a problem hiding this comment.
rename to AddressStakingPart
scarmuega
reviewed
Sep 30, 2025
crates/tx3-lang/src/ast.rs
Outdated
| NegateOp(NegateOp), | ||
| PropertyOp(PropertyOp), | ||
| UtxoRef(UtxoRef), | ||
| CardanoFunctions(crate::cardano::CardanoFunctions), |
Contributor
There was a problem hiding this comment.
add individual functions instead of aggregating as a single enum variant.
scarmuega
reviewed
Oct 14, 2025
Comment on lines
153
to
157
| ir::Expression::AdHocDirective(x) => match x.name.as_str() { | ||
| "cardano_address_payment_part" => Ok(extract_address_part(&x.data, 1..29)), | ||
| "cardano_address_staking_part" => Ok(extract_address_part(&x.data, 29..)), | ||
| _ => Ok(().as_data()), | ||
| }, |
Contributor
There was a problem hiding this comment.
relying on byte positions is too risky. Use pallas::ledger::addresses::Address to parse the bytes and return the data fragment we need.
Proxiweb
approved these changes
Nov 5, 2025
|
Sorry for this wrongly approved review. Too much github tabs opened. 😢 |
…ization-into-datum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.