feat(dialog): add directive options#117
Merged
DRiFTy17 merged 1 commit intotyler-technologies-oss:mainfrom Feb 20, 2026
Merged
Conversation
|
|
DRiFTy17
approved these changes
Feb 20, 2026
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Adds options to
IDialogServiceShowConfigurationcorresponding with latest createComponent api. This api is identical between Angular 20 and 21, so this add is compatible with this lib's Angular peer dep range.Additional information
The same add could also be made for other dynamic component services in the lib like
PopoverServicebut I figured these might get the sameshow->openmakeoverDialogServicedid and could have these options added then.