fix: resolve security vulnerabilities in dependencies#962
Open
tyler-josh wants to merge 5 commits intotyler-technologies-oss:mainfrom
Open
fix: resolve security vulnerabilities in dependencies#962tyler-josh wants to merge 5 commits intotyler-technologies-oss:mainfrom
tyler-josh wants to merge 5 commits intotyler-technologies-oss:mainfrom
Conversation
- Refine npm overrides to target only schema-utils ajv usage - Allow commitlint to use its required ajv version - All commit hooks now working properly
- Create dedicated folder for security audit working documents - Keep project repository clean of temporary analysis files
- Add strategic npm overrides to fix critical and high-severity vulnerabilities - Resolve babel-traverse code execution vulnerability (CRITICAL) - Fix multiple RegEx DoS vulnerabilities in @octokit, brace-expansion, @eslint/plugin-kit - Resolve prototype pollution in json5 and loader-utils - Add @custom-elements-manifest/analyzer dev dependency for build process - Refine ajv overrides to maintain commitlint compatibility - Maintain 100% test coverage and build compatibility - No breaking changes to public APIs Security impact: 29 → 4 vulnerabilities (86% reduction) Remaining 4 vulnerabilities resolved via upstream Tyler package updates
|
|
DRiFTy17
reviewed
Jul 24, 2025
Comment on lines
+12
to
+14
| CLAUDE.md | ||
| PROMPTS/ | ||
| .security-audit/ |
Collaborator
There was a problem hiding this comment.
Could you remove these unnecessary changes?
| { | ||
| "name": "@tylertech/forge", | ||
| "version": "3.10.0", | ||
| "version": "3.10.1", |
Collaborator
There was a problem hiding this comment.
Undo this change, the automation will handle bumping the version
Comment on lines
+118
to
+131
| "@eslint/plugin-kit": "^0.3.3", | ||
| "brace-expansion": "^2.0.2", | ||
| "json5": "^2.2.3", | ||
| "@babel/traverse": "^7.25.9", | ||
| "babel-traverse": "^6.26.0", | ||
| "@octokit/request": "^9.1.3", | ||
| "@octokit/request-error": "^6.1.5", | ||
| "@octokit/plugin-paginate-rest": "^11.4.0", | ||
| "loader-utils": "^3.3.1", | ||
| "istanbul-lib-instrument": "^6.0.3", | ||
| "html-minifier": "^4.0.0", | ||
| "schema-utils": { | ||
| "ajv": "^6.12.6" | ||
| } |
Collaborator
There was a problem hiding this comment.
I'd prefer to wait to merge this PR until the underlying dependencies (forge-cli and forge-build-tools) that rely on these are updated in this repo rather than using overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing