Bookstore additions for tutorials #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrii-ubskii
commented
Dec 4, 2025
| relates order, | ||
| relates item, | ||
| owns quantity, | ||
| owns price; |
Member
Author
There was a problem hiding this comment.
Most of these are shortening by combining multiple constraints on the same variable into one statement and replacing match not { ... }; insert ... with put.
Comment on lines
204
to
+205
| # user | ||
| match $city isa city; $city has name "San Francisco"; insert $user isa user; $user has id "u0001"; $user has name "Kevin Morrison"; $user has birth-date 1995-10-29; (location: $city, located: $user) isa locating;end; | ||
| match $city isa city, has name "San Francisco"; insert $user isa user, has id "u0001", has name "Kevin Morrison", has birth-date 1995-10-29, has total-spending 263.08, has loyalty-tier 1; (location: $city, located: $user) isa locating;end; |
Member
Author
There was a problem hiding this comment.
Users gained two new attributes, total-spending and loyalty-tier.
| attribute start-timestamp, value datetime; | ||
| attribute end-timestamp, value datetime; | ||
| attribute status, value string @regex("^(paid|dispatched|delivered|returned|canceled)$"); | ||
| attribute status, value string @regex("^(invalid|pending|paid|dispatched|delivered|returned|canceled)$"); |
Member
There was a problem hiding this comment.
you wanna swap this to @values(...) for proper 3.x usage?
flyingsilverfin
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We add two more attributes to the bookstore schema to accommodate the new TypeDB tutorials.
What are the changes implemented in this PR?
user:total-spendingandloyalty-tier(limited to 0..5),orderstates:invalidandpending,putqueries in data loading where possible to improve readability,