Create a Workflow type to capture an entire workflow file.
#812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarthross
force-pushed
the
enhancements
branch
from
b087f26 to
31b992e
Compare
Split out re-usable workflows for regular workflows Add needs Bin friendlier Triggers, added Workflow Call Add permissions and concurrency. Refactor needs Cleanup render of types and steps Cleaned up redundant empty string checks, added prefix, suffix to some compile matrix Add more trigger types
zarthross
force-pushed
the
enhancements
branch
from
31b992e to
546d028
Compare
|
@armanbilge Sorry for the size, but I wanted to get as much functionality into the new workflow type as possible. Do you mind looking over this and giving some feedback? Is this effort worth finishing up? Got some suggestions on how we can implement tests for the functionality here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new types
Workflow: Represents an entire workflow file, likeci.ymlandclean.ymlSecrets: How secrets in a job should be handled by called workflows.WorkflowTrigger: Represents a trigger, likepullandpush. This can and should be expanded to support more. TODO