Skip to content

Update sbt-header to 5.11.0 #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update sbt-header to 5.11.0 #835

wants to merge 3 commits into from

Conversation

@mzuehlke
Copy link
Collaborator

@mzuehlke mzuehlke commented Sep 12, 2025 •
edited
Loading

closes: #833

@mergify mergify bot added the core label Sep 12, 2025
rossabaker
rossabaker approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to need to be a major version bump of this plugin, I think.

armanbilge
armanbilge requested changes Sep 17, 2025
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Should bump the base version appropriately in this PR. Any compelling reasons to make this update?

@mzuehlke
Copy link
Collaborator Author

Correct
I will update the PR to update the base version

@rossabaker
Copy link
Member

This update will be necessary for eventual SBT 2 support, I think? I don't think it's urgent in the short term, but needed in the long term.

I'm also contemplating an improvement to sbt-header's SPDX handling. That would be a subsequent release.

@mzuehlke
Copy link
Collaborator Author

As @rossabaker sad, we will need a newer version latest when we want to support sbt 2.
In the meantime it depends if we want to always include updates to all used sbt plugins.
Which would lead to more often base version bumps. Or do this very selectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@armanbilge armanbilge armanbilge requested changes

@rossabaker rossabaker rossabaker approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mzuehlke @rossabaker @armanbilge