Skip to content

Fixes #1342 - plainToInstance loses values for the Map type if key matches a prototype value of Map #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixes #1342 - plainToInstance loses values for the Map type if key matches a prototype value of Map #1343

wants to merge 2 commits into from

Conversation

haug-den-lucas
Copy link

Description

This PR aims to fix Issue #1342
A detailed description+analysis can be found there.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified) => Existing test cases still apply
  • documentation added or updated => Current documentation is correct after applying this fix
  • I have run the project locally and verified that there are no errors

Fixes

#1342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@haug-den-lucas