Skip to content

Conversation

@eltos
Copy link
Contributor

@eltos eltos commented Feb 13, 2025

  • Fix another error "Cannot add type and string"
  • Fix two warning "Unnecessary import rename to same name"

For #52

@eltos eltos changed the title Typst 0.13 compatibility: Fix 1 error and 2 warnings Typst 0.13 compatibility: Fix 1 more error and 2 warnings Feb 13, 2025
Copy link
Member

@tingerrr tingerrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tingerrr
Copy link
Member

Thank you!

@tingerrr tingerrr merged commit 146fc17 into typst-community:main Feb 13, 2025
1 check passed
@eltos eltos mentioned this pull request Feb 13, 2025
@QuadnucYard
Copy link

Hello! When I searched the codebase, I found more cases add string and type not fixed.

) + ". Got " + type(it)

panic("Unknown date of type '" + type(it) + "' accepts: datetime, str, int, and object")

@tingerrr
Copy link
Member

PR would be appreciated, I'd prepare another patch release in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants