Fix retain comment to make more sense #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the retain doc comment from:
Note that this clones the vector even if
falways returnsfalse. To prevent that, you can first iterate over the vector yourself and then only callretainif your condition isfalsefor some element.To:
Note that this clones the vector even if
falways returnstrue. To prevent that, you can first iterate over the vector yourself and then only callretainif your condition isfalsefor some element.This makes more sense, since if
falways returns true, nothing is changed, so common sense would be that the vector wouldn't be cloned, but this comment says otherwise.