Conversation
LaurenzV
changed the title
LaurenzV
commented
Aug 14, 2025
Collaborator
Author
|
@laurmaedje WDYT? See here for example images: https://github.com/LaurenzV/krilla/pull/247/files Obviously should go through a round of manual testing with lots of fonts in Typst before actually landing, but it seems to work. |
Collaborator
Author
|
I should also note that CFF2 fonts are incredibly rare, thought judging by the Typst issue tracker it seems like at least on NixOS they are used. |
laurmaedje
reviewed
Aug 15, 2025
Member
laurmaedje
left a comment
laurmaedje
left a comment
There was a problem hiding this comment.
The approach looks solid to me! Very cool stuff. :)
I just have a few comments.
laurmaedje
reviewed
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs more testing, docs, etc., but I from playing around with it a bit I think this could be made to work. I tried to design the whole thing so it requires as few changes to the existing logic as possible, to hopefully prevent new bugs. Something that's probably worth measuring is whether the overhead from dynamic dispatch is very high.