feat: [CSA-4488] Allow extra scopes to be passed in to initializer #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProdigyTom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This just allows you to pass in extra scopes as
auth_paramsin the initializer for the ClassLink Omniauth strategy.The way it is set up it will always only ask for the
emailandprofilescopes, but for our use case we need to also request the rostering scope.With this change, the default scopes (
email, andprofile) will always be request, but if any additional scopes are passed in in theauth_params, they will be appended to the list of scopes that get requested from ClassLink.Thanks to @GURVARINDER for helping me with this.