Group By with Sorting Test and Documentation#155
Merged
Conversation
Removed unnecessary comments explaining the use of valueBuffer.
rlawrenc
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group By with Sorting
I made a new test that uses the current aggregate testing based on the first sorted unix timestamp and now use the sort operator beforehand. The test has the custom comparator operators for the first column and then does the aggregate on that successfully. This should mean now that any comparator functions defined should work so long as they work within adaptive sort beforehand. I updated the documentation on advanced queries to include the sorting operator with an example.