Merged
Conversation
This reverts commit 1faf3b2.
…ons in endorse/delete comment endpoints
d81442b to
d09667b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements per-user endorsed comment count tracking using a query-based approach rather than a stored counter column, avoiding data synchronization risks.
Behaviour: When a staff member endorses a student's async question comment, that endorsement is recorded on the comment itself (endorsedById). The new getEndorsedCountByCourse method can then be called at any time to get an up-to-date count of how many endorsed comments each student has in a course . This count is not yet surfaced in any API response or UI, but it is ready to be wired into future badge/achievement logic that rewards students for contributing high-quality answers.
Changes
New Query Method (AsyncQuestionService)
COUNT(*) GROUP BY creatorIdover endorsed comments for a courseMap<userId, count>Refactored Endorse & Delete Comment Endpoints (asyncQuestionController)
@Res()manual response handling with NestJS exceptions:Reverted Stored Column Approach
Closes #506
Type of change
yarn installHow Has This Been Tested?
Added 4 integration tests for getEndorsedCountByCourse covering:
Checklist:
console.logs, leftover unused logic, or anything else that was accidentally committed)