-
Notifications
You must be signed in to change notification settings - Fork 17
Remote control of spool; support downing specific ports; spool expiration #25
base: master
Are you sure you want to change the base?
Conversation
|
Rebased on top of my new version of #23 to get py26 tox support; fixed my py26 issues. Hopefully travis will be green now. |
|
@solarkennedy @jolynch @jnb Any of you want to take a look at this? |
hacheck/checker.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, to avoid issues with falsey values:
if extra_info.get('creation') is not None:
...
hacheck/spool.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth commenting why you first check with port=None?
…creation time alone.
|
lgtm |
|
|
This branch adds 3 primary features:
/spool/<service>/<port>/<query>will up or down a service remotely.This branch also includes my changes from #23 so I could run tests.