Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Conversation

@EvanKrall
Copy link

This branch adds 3 primary features:

  • The ability to down specific ports of a service.
  • Optionally (gated by a config flag), POSTs to /spool/<service>/<port>/<query> will up or down a service remotely.
  • Spool files can have an expiration date; if hacheck reads the file after its expiration, we delete it. We also keep track of creation time.

This branch also includes my changes from #23 so I could run tests.

@EvanKrall
Copy link
Author

Rebased on top of my new version of #23 to get py26 tox support; fixed my py26 issues. Hopefully travis will be green now.

@EvanKrall
Copy link
Author

@solarkennedy @jolynch @jnb Any of you want to take a look at this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, to avoid issues with falsey values:

if extra_info.get('creation') is not None:
    ...

hacheck/spool.py Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth commenting why you first check with port=None?

@jnb
Copy link

jnb commented Jul 18, 2015

lgtm

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants