Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.

Proposal for routing to named instances#1218

Open
kriskowal wants to merge 1 commit intomasterfrom
health-doc
Open

Proposal for routing to named instances#1218
kriskowal wants to merge 1 commit intomasterfrom
health-doc

Conversation

@kriskowal
Copy link
Contributor

This captures an idea that @mranney communicated for enabling health checks to specific instances through Hyperbahn.

r @jsu1212 @jcorbin @Raynos

@prashantv
Copy link
Contributor

I thought tags might be a nicer solution rather than doing something specifically for routing to an instance.

@jc-fireball
Copy link
Contributor

We need to discuss more about that. This is also a problem I am trying to solve right now. The instance name for some python service are same among some instance. For example, the "service A" have 10 processes are naming "serviceA"

@anson627
Copy link
Contributor

@junchaoWu interesting! How come different service instances have same name? aren't they named svc-0, svc-1, svc-2 etc.? I mean how deployment system or service controller would allow that.

@jc-fireball
Copy link
Contributor

This is a legacy issue from python uwsgi world. Uwsgi spawns up multi-process of instances and all of them listen to same port.

@anson627
Copy link
Contributor

thanks @junchaoWu! good to know.

@kriskowal
Copy link
Contributor Author

@prashantv Yes, tags instead of instance name is the more general approach. You also mentioned using vector clocks. Let’s work on another iteration of this proposal. Each service would need to regenerate an index[tag]:set based on the most advanced ad/unad per worker.

@kriskowal kriskowal added the node label Aug 27, 2015
@Raynos
Copy link
Contributor

Raynos commented Sep 17, 2015

I like this proposal as is.

It's really simple and can be shipped.

We are missing only one thing. Let's change init request and init response to add instance_name as an optional header so that it's done at init time and not at advertise time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants