Ubeyidah/ubeyida 13 add persistent chat memory

[ubeyidah]

Summary by CodeRabbit

• New Features

  • Added persistent chat memory that automatically saves your conversation history and restores it when you return.

• Bug Fixes

  • Enhanced chat session handling to reliably save your history when exiting or interrupting the application.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request implements persistent JSON-based chat history functionality. The changes add memory file configuration, introduce load and save methods to serialize chat history, integrate history loading during session creation, and call save_history() on exit or keyboard interrupt in the main loop. A duplicate constant definition is removed from config.

Changes

Cohort / File(s)	Summary
Configuration & Constants src/config.py	Added MEMORY_FILE and EXIT_WORD_LIST public constants; removed duplicate EXIT_WORD_LIST declaration to consolidate constant definitions.
Memory Persistence src/assistant.py	Integrated JSON-based history persistence: added _load_history() method to deserialize chat history from file, added save_history() method to serialize and write chat history to JSON, modified _create_chat_session() to load history on initialization.
Main Loop Integration main.py	Refactored input loop with nested try/except to separately handle KeyboardInterrupt from other errors; added save_history() calls before exit and interruption messages.
Documentation CHANGELOG.md	Added v0.2.0 release entry documenting persistent JSON memory feature and corrected get_history() usage note.

Sequence Diagram

sequenceDiagram
    participant User
    participant Main as main.py
    participant Assistant as assistant.py
    participant Memory as JSON File

    User->>Main: Start application
    Main->>Assistant: Create assistant instance
    Assistant->>Assistant: _load_history()
    Assistant->>Memory: Read MEMORY_FILE
    Memory-->>Assistant: Return history (or [])
    Assistant->>Assistant: Reconstruct Content/Part objects
    Note over Assistant: Chat session initialized with history

    User->>Main: Send messages
    Main->>Assistant: stream_message()
    Assistant-->>User: Stream response

    User->>Main: Exit or Ctrl+C
    Main->>Assistant: save_history()
    Assistant->>Assistant: Serialize chat_session.history
    Assistant->>Memory: Write JSON to MEMORY_FILE
    Memory-->>Assistant: File saved
    Main->>User: Print goodbye message

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Areas requiring extra attention:

• JSON serialization logic in _load_history() and save_history() methods: verify correct reconstruction of types.Content and types.Part objects from stored format, error handling for malformed JSON
• Integration point in main.py: ensure save_history() is called correctly in both normal exit and KeyboardInterrupt paths without missed scenarios
• Duplicate constant removal in src/config.py: confirm EXIT_WORD_LIST consolidation doesn't break any references or tests
• File I/O error handling: verify graceful degradation when memory file cannot be read/written

Poem

🐰 Whiskers twitched with glee so bright,
History now persists through night,
JSON dreams in files so neat,
Memory saved—our chats complete!
Hoppity-hop, the code's just right! 🎉

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ubeyidah/ubeyida-13-add-persistent-chat-memory

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a865a63 and cbc250d.

📒 Files selected for processing (4)

• CHANGELOG.md (1 hunks)
• main.py (1 hunks)
• src/assistant.py (3 hunks)
• src/config.py (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}