Add improvements to nautilus icons and folder icons#4359
Add improvements to nautilus icons and folder icons#4359Feichtmeier merged 13 commits intoubuntu:masterfrom
Conversation
|
@Jupi007 could you actually test this? This is very display color sensitive so I'm not sure testing this in my display. I have these parameters to adjust:
I will not add the pictogram darken overlay as a parameter to review since it will be sync with the back section's darken overlay. I also have to note that I still haven't made the default and mate variants for now so that once the accented variant is good to go, then I can proceed adding the rest of the source files. |
|
@ochi12 no problem, I will test it this afternoon once back home 👍 |
|
Yes, it works quite well with the other pictograms. |
|
@Jupi007 what do you think |
|
Sorry for the late reply, too much work these days... I pretty much like the B. example with dark+light shadow. |
|
@Jupi007 Currently I chose black @ 8 percent opacity for the dark area and and white @ 20 percent opacity for the light area for the Stamp effect. Do you have any knowledge on why mate and default colors are not included in the accented build. It would have been much easier instead of making 3 source files. I opened a separate issue here. We could implement it through this PR just so we immediately benefit from it. refactoring the source file for other variants is just a tedious (or so I thought, don't know the reason behind it) |
|
Sorry for the late reply.
Well it is quite simple : default and mate variants use a different style than simple accented ones. |
ok got it. What is the exact orange used for accents tho? |
|
@ochi12 Well it should be ubuntu's orange
|
|
@Jupi007 I just pushed new files for default and mate. Also applied the stamp effect to sizes 256 . Can you check it out before I generate the png files |
|
hi @ochi12 |
|
Please, let us know if we can get this in, UIF is getting close, so a decision here would be nice to have since this is a quite noticeable change |
|
could someone else render the pngs? I'm currently busy with other things.😅️ |
@ochi12 I think the CI can handle it once merged. |
nice |
|
Fyi added the update branch button so you can update a pr from master |
|
I just noticed that the new folders don't have the origami fold in the bottom right corner. Was that a deliberate choice to remove it or an oversight? I also noticed that the shadow between the front and the back looks stronger in the filemanager-app than in the folders or at least the orange in the filemanager-app looks brighter. |
I decided to remove it |






closes #4325