ci: Skip licenserecon during build-deb action#4372
Closed
adombeck wants to merge 1 commit intoubuntu:masterfrom
Closed
ci: Skip licenserecon during build-deb action#4372adombeck wants to merge 1 commit intoubuntu:masterfrom
adombeck wants to merge 1 commit intoubuntu:masterfrom
Conversation
We're about to merge a PR [1] which runs licenserecon aka lrc by default during the build-deb action to check the debian/copyright file. The motivation is that uploads to the archive can be rejected due to issues reported by lrc. [1] canonical/desktop-engineering#97 In this repo, it complains about a few differences between the debian/copyright file and the output of licensecheck: en: Versions: licenserecon '11.0' licensecheck '3.3.9-1ubuntu2' Parsing Source Tree .... Reading d/copyright .... Running licensecheck .... d/copyright | licensecheck GPL-3+ | CC0-1.0 gnome-shell/src/data/icons/scalable/status/wellbeing-symbolic.svg GPL-3+ | LGPL-2.1 gnome-shell/src/gnome-shell-sass/_common.scss GPL-3+ | CC0-1.0 gnome-shell/upstream/data/icons/scalable/status/wellbeing-symbolic.svg CC-BY-SA-4.0 | GPL-3+ icons/src/cursors/anicursorgen.py CC-BY-SA-4.0 | GPL-2 icons/src/cursors/render-cursors.py LGPL-3.0 | LGPL-3 icons/src/fullcolor/render-bitmaps.py LGPL-3.0 | LGPL-3 icons/src/scalable/extract-symbolic-icons.rb CC-BY-SA-4.0 | GPL-3 icons/src/symlinks/generate-symlinks.sh GPL-3+ | GPL-3 meson.build Since some of those are in the code from upstream gnome-shell, and yaru is already available in the archives, the easiest solution is to skip lrc when building yaru.
Contributor
Author
|
Closing in favor of #4373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're about to merge a PR [1] which runs licenserecon aka lrc by default during the build-deb action to check the debian/copyright file. The motivation is that uploads to the archive can be rejected due to issues reported by lrc.
[1] canonical/desktop-engineering#97
In this repo, it complains about a few differences between the debian/copyright file and the output of licensecheck:
Since some of those are in the code from upstream gnome-shell, and yaru is already available in the archives, the easiest solution is to skip lrc when building yaru.