Feature/data library #1686

k-burt-uch · 2025-04-02T18:29:22Z

Link to JIRA ticket if there is one:

New Features

Adds data library list creation and management to Discovery

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

github-actions · 2025-04-02T19:24:38Z

filepath	$$\textcolor{#23d18b}{\tt{passed}}$$	$$\textcolor{#f14c4c}{\tt{failed}}$$	$$\textcolor{#ffa500}{\tt{skipped}}$$	SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_requestor.py}}$$	$$\textcolor{#23d18b}{\tt{5}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#23d18b}{\tt{5}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_ras\_authn.py}}$$	$$\textcolor{#23d18b}{\tt{3}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#23d18b}{\tt{3}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_login\_page.py}}$$	$$\textcolor{#23d18b}{\tt{2}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#23d18b}{\tt{2}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_data\_upload.py}}$$	$$\textcolor{#23d18b}{\tt{2}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#23d18b}{\tt{2}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_indexing\_page.py}}$$	$$\textcolor{#23d18b}{\tt{2}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#23d18b}{\tt{2}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_audit\_service.py}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_homepage.py}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_pfb\_export.py}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_graph\_submit\_and\_query.py}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_gen3ff\_landing\_page.py}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#ffa500}{\tt{2}}$$	$$\textcolor{#ffa500}{\tt{2}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_register\_user.py}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#ffa500}{\tt{2}}$$	$$\textcolor{#ffa500}{\tt{2}}$$
$$\textcolor{#f14c4c}{\tt{tests/test\_discoverypage.py}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#666666}{\tt{0}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#23d18b}{\tt{18}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#ffa500}{\tt{4}}$$	$$\textcolor{#f14c4c}{\tt{23}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions · 2025-04-02T20:32:07Z

filepath	$$\textcolor{#f14c4c}{\tt{failed}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_discoverypage.py}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions · 2025-04-03T15:11:55Z

filepath	$$\textcolor{#f14c4c}{\tt{failed}}$$	$$\textcolor{#f14c4c}{\tt{error}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_discoverypage.py}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{2}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{2}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions · 2025-04-22T18:49:02Z

Please find the ci env pod logs here

mfshao · 2025-04-28T18:50:07Z

src/Discovery/Discovery.css


+.discovery-action-section {
+  display: flex;
+  flex-direction: row;


do we need this? there is only one element in that div

mfshao · 2025-04-28T18:56:13Z

src/Discovery/DiscoveryActionBar/DiscoveryDataLibrary.tsx

+            if (currentList) {
+              saveToList(currentList.label, currentList.value);
+            } else {
+              saveToList(currentList.label);


currentList might be null or undefined here?

mfshao · 2025-04-28T18:57:37Z

src/Discovery/reduxer.js

+  const mapStateToProps = (state) => ({
+    user: state.user,
+    discovery: state.discovery,
+    systemPopupActivated: !!state.popups?.systemUseWarnPopup,


why we need this props for data library?

mfshao · 2025-04-28T20:20:26Z

src/Discovery/DiscoveryActionBar/DiscoveryDataLibrary.tsx

+          disabled={error !== null || loading || data?.length === 0 || currentList === undefined || selectedResources.length === 0 || notLoggedIn}
+          onClick={() => {
+            if (currentList) {
+              saveToList(currentList.label, currentList.value);


should we call fetchLists() after this? Otherwise if I'm creating a new list, the list ID will remains undefined until I refresh the page 🤔

mfshao · 2025-04-28T20:25:44Z

src/components/ComboboxWithInput.jsx

@@ -0,0 +1,183 @@
+import React, {


wish we could have a story for this component in storybook

mfshao · 2025-04-28T20:26:34Z

src/index.ejs

      - https://*.quicksight.aws.amazon.com for loading AWS Quicksight dashboards into COVID-19 Home page
    -->
-    <meta http-equiv="Content-Security-Policy" content="default-src 'self' https://login.bionimbus.org https://wayf.incommonfederation.org; child-src blob:; img-src 'self' <%= htmlWebpackPlugin.options.imgSrc %> https://opendata.datacommons.io https://static.planx-pla.net data: https://*.s3.amazonaws.com blob:; script-src 'self' 'unsafe-eval' <%= htmlWebpackPlugin.options.scriptSrc %>; worker-src 'self' blob:; style-src 'self' 'unsafe-inline' https://fonts.googleapis.com; object-src 'none'; font-src 'self' data: https://fonts.googleapis.com https://fonts.gstatic.com; connect-src 'self' https://login.bionimbus.org https://wayf.incommonfederation.org https://opendata.datacommons.io https://static.planx-pla.net https://*.zendesk.com <%= htmlWebpackPlugin.options.connectSrc %>; frame-src <%= htmlWebpackPlugin.options.connectSrc %> 'self' https://auspice.planx-pla.net https://auspice.pandemicresponsecommons.org https://*.quicksight.aws.amazon.com;">
+    <meta http-equiv="Content-Security-Policy" content="default-src 'self'  http://localhost:8000 https://login.bionimbus.org https://wayf.incommonfederation.org; child-src blob:; img-src 'self' <%= htmlWebpackPlugin.options.imgSrc %> http://localhost:8000 https://opendata.datacommons.io https://static.planx-pla.net data: https://*.s3.amazonaws.com blob:; script-src 'self' 'unsafe-eval' <%= htmlWebpackPlugin.options.scriptSrc %>; worker-src 'self' blob:; style-src 'self' 'unsafe-inline' https://fonts.googleapis.com; object-src 'none'; font-src 'self' data: https://fonts.googleapis.com https://fonts.gstatic.com; connect-src 'self' https://login.bionimbus.org https://wayf.incommonfederation.org https://opendata.datacommons.io https://static.planx-pla.net https://*.zendesk.com <%= htmlWebpackPlugin.options.connectSrc %>; frame-src <%= htmlWebpackPlugin.options.connectSrc %> 'self' https://auspice.planx-pla.net https://auspice.pandemicresponsecommons.org https://*.quicksight.aws.amazon.com;">


is this for local testing? if so I suggest moving them to dev.html and only use them from there

mfshao · 2025-04-28T20:27:45Z

webpack.config.js

-  scriptSrcURLs.push(...['https://www.google-analytics.com', 'https://ssl.google-analytics.com', 'https://www.googletagmanager.com']);
-  connectSrcURLs.push(...['https://www.google-analytics.com', 'https://*.analytics.google.com', 'https://analytics.google.com', 'https://*.g.doubleclick.net']);
+  scriptSrcURLs.push(...['http://localhost:8000', 'http://www.google-analytics.com','https://www.google-analytics.com', 'https://ssl.google-analytics.com', 'https://www.googletagmanager.com']);
+  connectSrcURLs.push(...['http://localhost:8000', 'https://*.analytics.google.com', 'https://analytics.google.com', 'https://*.g.doubleclick.net']);


I don't think you need to do them here with google analytics

SpencerAxelrod · 2025-04-29T21:10:53Z

src/Discovery/DiscoveryActionBar/DiscoveryDataLibrary.tsx

+        <Button
+          loading={loading}
+          type='primary'
+          disabled={error !== null || loading || data?.length === 0 || currentList === undefined || selectedResources.length === 0 || notLoggedIn}


data?.length === 0 seems to prevent any initial list creation. It does not seem to increase when a user's first list is initially entered (after creation, but before a study is Saved to list), and subsequently can't be Saved to List as the button remains disabled. I have tested removing this and it resolves this issue

github-actions · 2025-04-29T21:57:35Z

filepath	$$\textcolor{#f14c4c}{\tt{failed}}$$	SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_discoverypage.py}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$	$$\textcolor{#f14c4c}{\tt{1}}$$

Please find the detailed integration test report here

Login here

Please find the ci env pod logs here

github-actions · 2025-06-16T18:21:27Z

filepath	skipped	SUBTOTAL
tests/test_discoverypage.py	1	1
TOTAL	1	1

Please find the detailed integration test report here

Login here

Please find the ci env pod logs here

github-actions · 2025-07-23T21:01:48Z

filepath	failed	SUBTOTAL
tests/test_discoverypage.py	1	1
TOTAL	1	1

Please find the detailed integration test report here (login here first)

github-actions · 2025-07-23T21:25:52Z

filepath	passed	failed	skipped	SUBTOTAL
tests/test_gen3ff_landing_page.py	0	0	2	2
tests/test_ras_authn.py	0	0	3	3
tests/test_requestor.py	5	0	0	5
tests/test_audit_service.py	1	0	0	1
tests/test_homepage.py	1	0	0	1
tests/test_register_user.py	2	0	0	2
tests/test_data_upload.py	2	0	0	2
tests/test_graph_submit_and_query.py	1	0	0	1
tests/test_login_page.py	2	0	0	2
tests/test_pfb_export.py	1	0	0	1
tests/test_discoverypage.py	0	1	0	1
TOTAL	15	1	5	21

Please find the detailed integration test report here (login here first)

github-actions · 2025-08-19T22:09:34Z

filepath	passed	failed	skipped	SUBTOTAL
tests/test_gen3ff_landing_page.py	0	0	2	2
tests/test_register_user.py	0	0	2	2
tests/test_ras_authn.py	0	0	3	3
tests/test_requestor.py	5	0	0	5
tests/test_audit_service.py	1	0	0	1
tests/test_data_upload.py	1	1	0	2
tests/test_login_page.py	2	0	0	2
tests/test_graph_submit_and_query.py	1	0	0	1
tests/test_homepage.py	1	0	0	1
tests/test_pfb_export.py	1	0	0	1
tests/test_discoverypage.py	0	1	0	1
TOTAL	12	2	7	21

Please find the detailed integration test report here (login here first)

add notifications with icons add doc for enableDataLibrary

github-actions · 2025-10-01T16:48:13Z

filepath	passed	failed	skipped	SUBTOTAL
tests/test_gen3ff_landing_page.py	0	0	2	2
tests/test_register_user.py	0	0	2	2
tests/test_ras_authn.py	0	0	3	3
tests/test_requestor.py	5	0	0	5
tests/test_audit_service.py	1	0	0	1
tests/test_data_upload.py	2	0	0	2
tests/test_login_page.py	2	0	0	2
tests/test_graph_submit_and_query.py	1	0	0	1
tests/test_pfb_export.py	1	0	0	1
tests/test_homepage.py	1	0	0	1
tests/test_discoverypage.py	0	1	0	1
TOTAL	13	1	7	21

Please find the detailed integration test report here

github-actions · 2025-11-05T00:01:18Z

filepath	passed	failed	skipped	SUBTOTAL
tests/test_requestor.py	5	0	0	5
tests/test_user_token.py	3	0	0	3
tests/test_audit_service.py	1	0	0	1
tests/test_data_upload.py	2	0	0	2
tests/test_login_page.py	2	0	0	2
tests/test_graph_submit_and_query.py	1	0	0	1
tests/test_homepage.py	1	0	0	1
tests/test_workspace.py	1	0	0	1
tests/test_pfb_export.py	1	0	0	1
tests/test_ras_authn.py	0	0	3	3
tests/test_gen3ff_landing_page.py	0	0	2	2
tests/test_register_user.py	0	0	2	2
tests/test_dbgap.py	0	1	0	1
tests/test_discoverypage.py	0	1	0	1
TOTAL	17	2	7	26

Please find the detailed integration test report here

Please find the Github Action logs here

PlanXCyborg added the TestDiscoveryPage label Apr 2, 2025

mfshao reviewed Apr 28, 2025

View reviewed changes

SpencerAxelrod reviewed Apr 29, 2025

View reviewed changes

k-burt-uch removed the TestDiscoveryPage label Jul 23, 2025

k-burt-uch force-pushed the feature/data_library branch from a81f1d8 to e7192e9 Compare August 19, 2025 21:44

craigrbarnes and others added 9 commits October 1, 2025 11:03

test dictionary add to library

17a50bc

add disable to ComboboxWithInput

cba179a

clean up code

0384937

add notifications with icons add doc for enableDataLibrary

update placeholder text when not logged in

fb3dd73

restore dictionary and schema

df5b593

update Discovery test

b0efa60

add Data Library icon, list.svg

8f34b1a

remove data?.length === 0

1ead64a

Fix checkboxes on Discovery

bd45089

k-burt-uch force-pushed the feature/data_library branch from e7192e9 to bd45089 Compare October 1, 2025 16:06

Use PATCH when updating lists

0f7938f

Feature/data library #1686

Are you sure you want to change the base?

Feature/data library #1686

Uh oh!

Conversation

k-burt-uch commented Apr 2, 2025

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

Uh oh!

github-actions bot commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

github-actions bot commented Aug 19, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants