Skip to content

Conversation

@mfshao
Copy link
Collaborator

@mfshao mfshao commented Dec 18, 2025

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/HP-2414 https://ctds-planx.atlassian.net/browse/HP-2415

New Features

Breaking Changes

Bug Fixes

Improvements

  • Discovery: add file manifest and external file metadata information to datasetDownload and exportToWorkspace Faro events
  • Discovery: add a new Faro event dataFileDownload

Dependency updates

Deployment changes

@github-actions
Copy link

filepath passed skipped SUBTOTAL
tests/test_requestor.py 5 0 5
tests/test_user_token.py 3 0 3
tests/test_audit_service.py 1 0 1
tests/test_data_upload.py 2 0 2
tests/test_login_page.py 2 0 2
tests/test_graph_submit_and_query.py 1 0 1
tests/test_register_user.py 2 0 2
tests/test_dbgap.py 1 0 1
tests/test_homepage.py 1 0 1
tests/test_discoverypage.py 1 0 1
tests/test_workspace.py 1 0 1
tests/test_pfb_export.py 1 0 1
tests/test_ras_authn.py 0 3 3
tests/test_gen3ff_landing_page.py 0 2 2
TOTAL 21 5 26

Please find the detailed integration test report here

Please find the Github Action logs here

Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!
• Code looks good
• Confirmed code works locally in QA, and able to download files
• Confirmed fires requests to https://faro.planx-pla.net/collect
• Unable to confirm if data shows up as expected in data access reporting

@mfshao mfshao merged commit 6a9201c into master Jan 7, 2026
14 checks passed
@mfshao mfshao deleted the feat/faro-event-improve branch January 7, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants