Skip to content

Conversation

@nss10
Copy link
Contributor

@nss10 nss10 commented Oct 31, 2025

Link to JIRA ticket if there is one: PD-77

New Features

Breaking Changes

Bug Fixes

Improvements

  • Remove unused volumes and volume mounts from fence and other related services

Dependency updates

Deployment changes

@nss10 nss10 changed the title Initial pass, eliminate secrets and configmaps that are linked to local_settings.py Eliminate secrets and configmaps that are linked to local_settings.py Oct 31, 2025
@github-actions
Copy link

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 15 0 0 15
tests/test_dicom_viewer.py 4 0 0 4
tests/test_centralized_auth.py 16 0 0 16
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_audit_service.py 3 0 3 6
tests/test_guppy_service.py 8 0 0 8
tests/test_data_upload.py 8 0 1 9
tests/test_dbgap.py 4 0 1 5
tests/test_presigned_url.py 7 0 0 7
tests/test_requestor.py 5 0 0 5
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_study_viewer.py 3 0 0 3
tests/test_user_data_library.py 2 0 1 3
tests/test_oidc_client.py 2 0 0 2
tests/test_login_page.py 2 0 0 2
tests/test_client_credentials.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
tests/test_manifest_service.py 1 0 0 1
tests/test_discoverypage.py 1 0 0 1
tests/test_aggregate_mds.py 1 0 0 1
tests/test_workspace.py 1 0 0 1
tests/test_google_data_access.py 1 0 0 1
tests/test_homepage.py 1 0 0 1
tests/test_gen3_workflow.py 0 0 11 11
tests/test_ras_authn.py 0 0 3 3
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_env_sanity.py 0 0 1 1
tests/test_etl.py 0 0 1 1
tests/test_register_user.py 0 0 2 2
tests/test_pfb_export.py 0 1 0 1
TOTAL 109 1 27 137

Please find the detailed integration test report here

Please find the Github Action logs here

@nss10 nss10 marked this pull request as ready for review November 3, 2025 20:40
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

filepath passed error skipped SUBTOTAL
tests/test_oauth2.py 15 0 0 15
tests/test_dicom_viewer.py 4 0 0 4
tests/test_centralized_auth.py 16 0 0 16
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_audit_service.py 3 0 3 6
tests/test_data_upload.py 7 2 1 10
tests/test_pfb_export.py 1 0 0 1
tests/test_presigned_url.py 7 0 0 7
tests/test_guppy_service.py 8 0 0 8
tests/test_requestor.py 5 0 0 5
tests/test_dbgap.py 4 0 1 5
tests/test_user_token.py 5 0 0 5
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_data_library.py 2 0 1 3
tests/test_oidc_client.py 2 0 0 2
tests/test_client_credentials.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
tests/test_manifest_service.py 1 0 0 1
tests/test_study_viewer.py 3 0 0 3
tests/test_discoverypage.py 1 0 0 1
tests/test_aggregate_mds.py 1 0 0 1
tests/test_workspace.py 1 0 0 1
tests/test_google_data_access.py 1 0 0 1
tests/test_login_page.py 2 0 0 2
tests/test_homepage.py 1 0 0 1
tests/test_gen3_workflow.py 0 0 11 11
tests/test_ras_authn.py 0 0 3 3
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_register_user.py 0 0 2 2
tests/test_env_sanity.py 0 0 1 1
tests/test_etl.py 0 0 1 1
TOTAL 109 2 27 138

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link

filepath passed failed error skipped SUBTOTAL
tests/test_oauth2.py 15 0 0 0 15
tests/test_dicom_viewer.py 4 0 0 0 4
tests/test_centralized_auth.py 16 0 0 0 16
tests/test_graph_submit_and_query.py 13 0 0 1 14
tests/test_audit_service.py 3 0 0 3 6
tests/test_pfb_export.py 1 0 0 0 1
tests/test_data_upload.py 5 0 5 1 11
tests/test_guppy_service.py 8 0 0 0 8
tests/test_presigned_url.py 7 0 0 0 7
tests/test_dbgap.py 4 0 0 1 5
tests/test_requestor.py 1 4 1 0 6
tests/test_drs_endpoint.py 4 0 0 0 4
tests/test_user_token.py 2 3 0 0 5
tests/test_gen3_workflow.py 0 0 0 11 11
tests/test_ras_authn.py 0 0 0 3 3
tests/test_user_data_library.py 0 2 2 1 5
tests/test_gen3ff_landing_page.py 0 0 0 2 2
tests/test_env_sanity.py 0 0 0 1 1
tests/test_etl.py 0 0 0 1 1
tests/test_study_viewer.py 0 3 1 0 4
tests/test_google_data_access.py 0 0 1 0 1
tests/test_discoverypage.py 0 1 1 0 2
tests/test_login_page.py 0 2 0 0 2
tests/test_homepage.py 0 1 0 0 1
tests/test_aggregate_mds.py 0 1 0 0 1
tests/test_client_credentials.py 0 1 0 0 1
tests/test_workspace.py 0 1 0 0 1
tests/test_oidc_client.py 0 2 0 0 2
tests/test_gen3client.py 0 1 0 0 1
tests/test_manifest_service.py 0 1 0 0 1
tests/test_register_user.py 0 2 0 0 2
TOTAL 83 25 11 25 144

Please find the detailed integration test report here

Please find the Github Action logs here

Comment on lines -445 to -448
- name: "creds-volume"
readOnly: true
mountPath: "/var/www/fence/creds.json"
subPath: creds.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure we don't use creds.json anymore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sai and I looked into it and couldn't find a reference for it in the fence.
https://cdis.slack.com/archives/C02SH3UB2T0/p1761936261950959

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though there seems to be quite a lot of failing tests 😅

@github-actions
Copy link

filepath passed error skipped SUBTOTAL
tests/test_oauth2.py 15 0 0 15
tests/test_dicom_viewer.py 4 0 0 4
tests/test_centralized_auth.py 16 0 0 16
tests/test_graph_submit_and_query.py 13 1 1 15
tests/test_audit_service.py 3 0 3 6
tests/test_pfb_export.py 1 0 0 1
tests/test_presigned_url.py 7 0 0 7
tests/test_guppy_service.py 8 0 0 8
tests/test_requestor.py 5 0 0 5
tests/test_dbgap.py 4 0 1 5
tests/test_data_upload.py 8 0 1 9
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_data_library.py 2 0 1 3
tests/test_user_token.py 5 0 0 5
tests/test_study_viewer.py 3 0 0 3
tests/test_register_user.py 2 0 0 2
tests/test_discoverypage.py 1 0 0 1
tests/test_login_page.py 2 0 0 2
tests/test_oidc_client.py 2 0 0 2
tests/test_workspace.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
tests/test_manifest_service.py 1 0 0 1
tests/test_homepage.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_aggregate_mds.py 1 0 0 1
tests/test_google_data_access.py 1 0 0 1
tests/test_gen3_workflow.py 0 0 11 11
tests/test_ras_authn.py 0 0 3 3
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_etl.py 0 0 1 1
tests/test_env_sanity.py 0 0 1 1
TOTAL 112 1 25 138

Please find the detailed integration test report here

Please find the Github Action logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants