Change the __iter__ implementation of the Config
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulineribeyre
previously approved these changes
Nov 14, 2024
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
mfshao
reviewed
Nov 15, 2024
.github/workflows/pypi.yaml
Outdated
| with: | ||
| PYTHON_VERSION: '3.9' | ||
| # the package was registered under someone's personal test-pypi account, so we | ||
| # can't push there |
There was a problem hiding this comment.
is this true for this repo? if so can we move it out to gen3?
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch. I need to check on that. I got the pypi.yaml file from gen3utils and like a computer, my mind completely ignored the comments 😅
There was a problem hiding this comment.
yeah lets verify that and I believe if this package is under gen3 on pypi, I also need to config the pypi creds for this repo in order for this workflow to work
Contributor
Author
Contributor
There was a problem hiding this comment.
It'll be created automatically, we just need to remove this comment from here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
keyinstead of akey,valuepair. Use.items()to replicate thekey,valuepair functionality.