Require first & last name on project requests#637
Open
helbashandy wants to merge 18 commits intodevelopfrom
Open
Require first & last name on project requests#637helbashandy wants to merge 18 commits intodevelopfrom
helbashandy wants to merge 18 commits intodevelopfrom
Conversation
Collaborator
Author
|
Hi @matthew-li - Please note that I've updated the implementation by replacing the use of This change was made for two key reasons:
|
matthew-li
reviewed
Aug 19, 2024
coldfront/core/utils/permissions.py
Outdated
| :return: | ||
| """ | ||
| if request.user.first_name == '' or request.user.last_name == '': | ||
| messages.error(request, 'You must set your first and last name on your account before you can make requests.') |
Collaborator
There was a problem hiding this comment.
Link directly to the update form within the message?
matthew-li
reviewed
Aug 19, 2024
…ate allocation periods.
…icular allowance type into a method
…enewal request into method
… FCAs and PCAs; add constraints
* Adds a permissions.py file as an initial step to centeralize permissions across the app. * Adds first and last name check to the test_func on requests to create or join a project. * Creates a generic wrapper decorator to be used around test_func to allow gradual progressive refactor of test_func towards a more centralized and modular permissions management solution. * Adds test for request creation Fixes #605
743ad96 to
ea63ec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a permissions.py file as an initial step to centeralize
permissions across the app.
Adds first and last name check to the test_func on requests to create or join a project.
Creates a generic wrapper decorator to be used around test_func to
allow gradual progressive refactor of test_func towards a more
centralized and modular permissions management solution.
Fixes #605
Type of change
**** Please delete options that are not relevant. ****
How Has This Been Tested?
**** Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration ****
PR Self Evaluation
strikethrough things that don’t make sense for your PR
- [ ] I have made corresponding changes to the documentation (if needed)