Skip to content

Conversation

@matthew-li
Copy link
Collaborator

Description

**** Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ****

  • Added logic to send an email to a configured list of administrators when an FSA request is approved (and ready for processing).
  • Renamed FSA notification service methods for clarity.
  • Updated the email sent to users when an FSA request is completed to include the approved amount, not the requested amount.
  • Updated tests.

Type of change

**** Please delete options that are not relevant. ****

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

**** Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. ****

  • Ensure that the test suite passes on GitHub Actions.

PR Self Evaluation

Strikethrough things that don’t make sense for your PR.

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if needed)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

  email
* Send notification to admins when FSA request is approved
@matthew-li matthew-li merged commit 8745133 into upgrade/rocky8-python3.13-develop Feb 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant