Add dedicated logger for management commands#742
Open
matthew-li wants to merge 4 commits intoupgrade/rocky8-python3.13-developfrom
Open
Add dedicated logger for management commands#742matthew-li wants to merge 4 commits intoupgrade/rocky8-python3.13-developfrom
matthew-li wants to merge 4 commits intoupgrade/rocky8-python3.13-developfrom
Conversation
except when file handler writes to stdout * Update commands that write to stdout/stderr to use the logger (preserving console output in monolithic environments, and only writing to the log in K8s-based environments) * Allow extra log data to be processed by structlog * Consolidate some multi-line logs into one
* Skip logging when testing in containerized environments * Stream logs to stdout in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
**** Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ****
coldfront.commandslogger, to be used for management commands, that writes to the console and to a file in monolithic deployments, and only to the console in containerized deployments.--dry_runmode.structlogto process extra log data.Type of change
**** Please delete options that are not relevant. ****
How Has This Been Tested?
**** Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. ****
PR Self Evaluation
Strikethrough things that don’t make sense for your PR.