Open
Conversation
rather than per-second. Note that this only changes the timer, not the display, which still includes seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the countdown timer once-per-second is inefficient. The actual marathon start will probably not be accurate to the minute, let alone to the second. Consuming 60 times the CPU for per-second updates isn't worthwhile.
I added code to schedule the countdown timer for per-minute updates, rather than per-second. Note that this only changes the timer, not the display, which still includes seconds. I was also coding without a Java compiler, so I don't even know if this works. If it does, however, you can remove the seconds from the countdown display.