Skip to content

Conversation

@josephtclegg
Copy link
Contributor

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

Implemented a UIPageViewController to handle all the functionality previously delegated to a menu view controller.

Approach

The UIPageViewController enables the user to swipe through different views in the iOS app as opposed to tapping buttons on a menu to select which view to look at.

Learning

https://spin.atomicobject.com/2015/12/23/swift-uipageviewcontroller-tutorial/
This tutorial, while slightly outdated, more or less walks you through the basic functionality of a UIPageViewController.

Additionally, the following StackOverflow answer was helpful in programmatically setting the swiping animation to be a sliding animation rather than a page curl:

https://stackoverflow.com/a/40973156/4694958

Checklist

  • My branch follows the branch naming scheme of UCLA Radio, and can merge into master without error.
  • My code follows the code style of this project, and I have linted it to confirm this.
  • I have added tests that prove my fix is effective or that my feature works.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • All new and existing tests passed.

Platform

Operating System:
iOs

@haejinjo haejinjo self-requested a review November 15, 2018 04:40
Joseph Clegg and others added 5 commits November 24, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants