-
Notifications
You must be signed in to change notification settings - Fork 3
Joseph/ui page view controller #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
josephtclegg
wants to merge
26
commits into
master
Choose a base branch
from
joseph/UIPageViewController
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g sliding functionality.
… our previous menu view via swiping.
…ally changed the background so that views scroll on top of a static background image.
…yingContainerView.
…owPlayingView in a new NowPlayingContainerView class.
…t functionality from the android app.
…lview apparently, and scrollToMenuIndex not responding
…view controller sliding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Purpose
Implemented a UIPageViewController to handle all the functionality previously delegated to a menu view controller.
Approach
The UIPageViewController enables the user to swipe through different views in the iOS app as opposed to tapping buttons on a menu to select which view to look at.
Learning
https://spin.atomicobject.com/2015/12/23/swift-uipageviewcontroller-tutorial/
This tutorial, while slightly outdated, more or less walks you through the basic functionality of a UIPageViewController.
Additionally, the following StackOverflow answer was helpful in programmatically setting the swiping animation to be a sliding animation rather than a page curl:
https://stackoverflow.com/a/40973156/4694958
Checklist
masterwithout error.Platform
Operating System:
iOs