Skip to content

fix: cluster scoped issue and typo #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: cluster scoped issue and typo #87

wants to merge 1 commit into from

Conversation

fengxsong
Copy link

process of ShouldManage function should be

  1. check if clusterScope is set to true
  2. fallback to determine whether the value in annotation is equal to constants.

@fengxsong
Copy link
Author

the other repostory has the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fengxsong