Conversation
ccheung93
requested changes
Jan 23, 2026
Collaborator
ccheung93
left a comment
ccheung93
left a comment
There was a problem hiding this comment.
instead of adding it here, i think it would make more sense to add xja, xjc, xla, xlc, yla, ylc to the variable declaration of P_eff
Collaborator
Author
|
Sure. I proposed a simple workaround to avoid it. However, that incorrect variable declaration is the source of possible errors here. |
Collaborator
|
could you pull and check the results are the same? |
Collaborator
Author
|
Yes, this works as expected and is coded much cleaner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Context
Description: