Open
Conversation
…er, footer, hero, goals, and features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BUILT:
-> header, goals, features, repos, CTA, footer
-> button.tsx based on global scss; made small change to the global button component to match the figma sizing
-> features: topicCard and topicGrid components
-> repos: accodionItem and accordion components
-> responsiveness on most of the site, using clamp and breakpoints. any fixes needed mentioned below
-> imported needed assets from figma
Fixes # (issue)
RESPONSIVNESS
⦁ bottom right hero image need responsiveness
⦁ header needs hamburger menu responsiveness
⦁ repo section should get scaling on font size for responsiveness
LINKS
⦁ links to all the sections are overshoot a little bit
⦁ links to the cards will cause an error because there is nothing there
⦁ links in the hero buttons and repo buttons should also change dynamically based on the login status
⦁ logout link broken; site doesn't exist yet
⦁ used some embedded colors picked from Figma instead of CSS variables, most have FIX ME next to them. Couldn't get the variables working for some reason, but I did my best to include both the variable and the hard coded color.
COLOR: hard coded some colors, unfortunately couldn't get the CSS color variables fully working. Most have FIXME by them, and I did my best to include the variable color in addition to the emebed color.
Type of change