Edited user settings themes and fixed settings reset issue#46
Open
MsMaddie05 wants to merge 3 commits intoufosc:mainfrom
Open
Edited user settings themes and fixed settings reset issue#46MsMaddie05 wants to merge 3 commits intoufosc:mainfrom
MsMaddie05 wants to merge 3 commits intoufosc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when switching to other tabs, the extension/website didn't correctly keep track of the themes chosen in the settings tab. For instance, when you originally picked a theme in the settings tab, it reset when you returned to the settings tab instead of when the user manually changes the theme. Additionally, certain elements (such as the GooberInfo and GooberMenu) hadn't been updated with the theme yet, so that’s another issue that I helped fix!!