updating MYNN-EDMF pointer #209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clark-evans
approved these changes
Jan 31, 2026
Collaborator
clark-evans
left a comment
clark-evans
left a comment
There was a problem hiding this comment.
Always fun to see the slight tuning differences between code versions. The comparison script shows that there are differences, but they are small as expected (and are much less than those in the recent RRTMG equation of time PR), and all of the tests pass. Let's discuss whether a short real-time test would be beneficial before merging, but I don't know that one is needed.
dustinswales
approved these changes
Feb 2, 2026
AndersJensen-NOAA
approved these changes
Feb 6, 2026
Collaborator
AndersJensen-NOAA
left a comment
AndersJensen-NOAA
left a comment
There was a problem hiding this comment.
This comment !ensure adequate RH & q1 when qi is at least 1e-9 (above the PBLH) should be updated to 1e-10, consistent with the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR syncs the MYNN-EDMF submodule with that recently committed to WRF. No major changes in behavior are expected. Most of the changes are cosmetic code cleaning and some minor revision of the code to better match the simplified description in the MYNN-EDMF tech note.
Compiled and testing in a MPAS case study. This submodule also passed WRF's regression testing.
Priority Reviewers