Open
Conversation
Fix dev/core#5722 Use smarty variable which is a boolean instead of the token which is localized
A few forms present a dropdown for "From Email Address", and most of them were not correctly setting the default. I investigated and found a couple causes: 1. Some forms just didn't bother to set it 2. Some forms *tried* to set it, but it got mangled by the html purifier For the not-even-trying forms, a pretty simple catch-all solution is to put the default at the top of the list, thus the change to CRM_Core_BAO_Email::domainEmails For the ones that were trying and failing, I added the field to getFieldsToExcludeFromPurification.
Now that the last 2 domain-specific option groups have been dealt with: - civicrm#31909 - civicrm#31924 ... we can stop using this godawful is_domain column for good. The OptionValue table is complex enough without it!
…value This does the same thing as before, in one much simpler line.
dev/core#5722 AdminUI - Fix Manage ACLs mode column
UtilsArray - Refactor out uses of deprecated CRM_Utils_Array::value
Import code consolidation, membership import
Update existing navigation labels to match new 'Site Email Address' l…
Add guard around CIVICRM_IFRAME constant
OptionGroup - Deprecate isDomainOptionGroup function
Decommission thresholdQuery, only call legacy hook from backward compat extension
CiviCase - Fix links and breadcrumbs when viewing case without cid in url
[REF] Use tokenProcessor to render display name
a030458 to
e534609
Compare
dev/financial#230 - don't send email receipt when changing payment method on a contribution
dev/core#5578 Adding Recurring tokens to Contribution/Membership toke…
dev/core#5725 ScheduledCommunications - Increase length of fields used by SearchKit
6.0 to master
Remove "Cleanup Caches and Update Paths" page, leave a Clear Caches button and deprecate update/reset paths
Deprecate legacy parameters to Address::format()
Ensure modelProps has contributionID
e534609 to
47edf98
Compare
47edf98 to
f69eb7a
Compare
f69eb7a to
bd28191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Remove the theme level default theme handling.
Follow up on switching default to Minetta at setting level.
Before
After