Skip to content

Remove default theme#9

Open
ufundo wants to merge 155 commits intoriverlea-rollout-2from
remove-default-theme
Open

Remove default theme#9
ufundo wants to merge 155 commits intoriverlea-rollout-2from
remove-default-theme

Conversation

@ufundo
Copy link
Owner

@ufundo ufundo commented Feb 7, 2025

Overview

Remove the theme level default theme handling.

Follow up on switching default to Minetta at setting level.

Before

  • there's a default for theme settings at the setting level "default"
  • there's a default for theme at the theme level, which gives you Greenwich
  • theme options list in Display Settings includes an extra option "Automatic" which gives you Greenwich
  • if you select a theme from an extension, then disable the extension, you'll get Greenwich
  • there's a hard dependency on Greenwich being an option, and Greenwich extension is required (and hidden)

After

  • theme options list in Display Settings only includes explicit choices for the themes that are available
  • you can enable/disable whatever extensions you want (including Greenwich)
  • if you select a theme from an extension, then disable the extension, you'll get unthemed - and (realise what you've done and do something about it)

colemanw and others added 23 commits February 7, 2025 07:23
A few forms present a dropdown for "From Email Address",
and most of them were not correctly setting the default.
I investigated and found a couple causes:

1. Some forms just didn't bother to set it
2. Some forms *tried* to set it, but it got mangled by the html purifier

For the not-even-trying forms, a pretty simple catch-all solution is to
put the default at the top of the list, thus the change to CRM_Core_BAO_Email::domainEmails

For the ones that were trying and failing, I added the field to
getFieldsToExcludeFromPurification.
Now that the last 2 domain-specific option groups have been dealt with:

- civicrm#31909
- civicrm#31924

... we can stop using this godawful is_domain column for good.
The OptionValue table is complex enough without it!
…value

This does the same thing as before, in one much simpler line.
dev/core#5722 AdminUI - Fix Manage ACLs mode column
UtilsArray - Refactor out uses of deprecated CRM_Utils_Array::value
Import code consolidation, membership import
Update existing navigation labels to match new 'Site Email Address' l…
Add guard around CIVICRM_IFRAME constant
OptionGroup - Deprecate isDomainOptionGroup function
Decommission thresholdQuery, only call legacy hook from backward compat extension
@ufundo ufundo force-pushed the remove-default-theme branch 2 times, most recently from a030458 to e534609 Compare February 11, 2025 23:13
seamuslee001 and others added 7 commits February 12, 2025 10:42
dev/financial#230 - don't send email receipt when changing payment method on a contribution
dev/core#5578 Adding Recurring tokens to Contribution/Membership toke…
dev/core#5725 ScheduledCommunications - Increase length of fields used by SearchKit
Remove "Cleanup Caches and Update Paths" page, leave a Clear Caches button and deprecate update/reset paths
Deprecate legacy parameters to Address::format()
@ufundo ufundo force-pushed the remove-default-theme branch from e534609 to 47edf98 Compare February 12, 2025 08:26
@ufundo ufundo force-pushed the remove-default-theme branch from 47edf98 to f69eb7a Compare February 12, 2025 08:30
@ufundo ufundo force-pushed the remove-default-theme branch from f69eb7a to bd28191 Compare February 12, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.