Sync GPR depth sliders across multiple .sgy files#662
Open
VladislavGroshkov wants to merge 7 commits intomasterfrom
Open
Sync GPR depth sliders across multiple .sgy files#662VladislavGroshkov wants to merge 7 commits intomasterfrom
VladislavGroshkov wants to merge 7 commits intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Extract HoverHandle base class for tooltip/drag logic - Replace Model.syncDepthFromChart with event-driven DepthRangeSyncListener - Migrate meta depth range field from Range (double) to IndexRange (int)
src/main/java/com/ugcs/geohammer/model/element/AuxElementEditHandler.java
Fixed
Show fixed
Hide fixed
…ooltip instance between depth sliders, eliminate redundant depthSliderPressed field, and stop serializing deprecated amplitudeRange in TraceMeta
| canvas.setOnMousePressed(mousePressHandler); | ||
| canvas.setOnMouseReleased(mouseReleaseHandler); | ||
| canvas.setOnMouseMoved(mouseMoveHandler); | ||
| canvas.setOnMouseExited(event -> auxEditHandler.mouseExitHandle(GPRChart.this)); |
Check warning
Code scanning / PMD
Useless qualified this usage in the same class. Warning
| public boolean mouseExitHandle(ScrollableData profField) { | ||
| if (lastHovered != null) { | ||
| lastHovered.mouseHoverEndHandle(null, profField); | ||
| lastHovered = null; |
Check warning
Code scanning / PMD
Assigning an Object to null is a code smell. Consider refactoring. Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.