Migrate project to Vite for asset bundling #167
Open
vivgui wants to merge 2 commits intouicrooks:devfrom
Open
Conversation
|
Hey guys, at barrel created a Vite/Shopify plugin that I think you will love (: vite-plugin-shopify.mp4 |
Author
|
@montalvomiguelo what's the github repo? would like to take a look |
Author
|
I wanted to follow up on this, is there anything you want me to change/talk about before this can be approved? |
|
when is this going to be approved? |
|
+1 would love to see this implemented! |
|
+1 this is just what I'm missing from the current implementation |
|
+1 |
1 similar comment
|
+1 |
|
Adapted OP's Vite implementation for use with Alpine.js if anyone wants to check it out here. Havn't got it working with Shopify CLI v3 yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project currently uses webpack for assets bundling but there's an interest in switching to Vite. This PR attempts to do that migration. I first tested this on the foundation theme (you can see my repo fork here) and things worked correctly.
One major thing that the migration to Vite changed is that Vite doesn't use
.browserslistrcfor setting browser compatibility, it usesesbuildinstead so the.config/.browserslistrcfile is not needed.Besides that, I tried my best to replace all the webpack-specific functionality using Vite plugins and configurations.
I know this is a significant change and I'm open to discussing how to best approach it. I just wanted to demonstrate that migrating to Vite is possible and worthwhile.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch, not themainbranchIf adding a new feature, the PR's description includes:
Other information: