Skip to content

Merge of nullable params back into master repo#1

Merged
mgrundkoetter merged 13 commits intoujamii:masterfrom
qbus-agentur:nullable-getter-returndeclarations
Jul 19, 2019
Merged

Merge of nullable params back into master repo#1
mgrundkoetter merged 13 commits intoujamii:masterfrom
qbus-agentur:nullable-getter-returndeclarations

Conversation

@mgrundkoetter
Copy link
Member

No description provided.

@mgrundkoetter mgrundkoetter merged commit 03ee928 into ujamii:master Jul 19, 2019
@bnf
Copy link
Contributor

bnf commented Aug 23, 2019

Thanks for merging our branch, much appreciated!

One note though, the branch relied on a open pull request in gossi/php-code-generator:
phpowermove/php-code-generator#64 – therefore I didn't open a pull request to your repository yet.

I should have added the patch to the composer.json in our nullable-getter-returndeclarations branch – anyway, here is a pull request to do that now:
#2
This fixes the API (re)generation. That change can be removed once gossi/php-code-generator merges the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants