Add DLL export symbols and fix formatting#126
Open
munechika-koyo wants to merge 2 commits intoukaea:developfrom
Open
Add DLL export symbols and fix formatting#126munechika-koyo wants to merge 2 commits intoukaea:developfrom
munechika-koyo wants to merge 2 commits intoukaea:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
When I compile the
imas-corelibrary with the UDA backend on Windows, I encounter linker errors caused by unexported symbols.Below, I show where each unexported symbol is used in the
imas-coresources.freeDataBlockhttps://github.com/iterorganization/IMAS-Core/blob/develop/src/uda/uda_backend.cpp#L882
ResultListhttps://github.com/iterorganization/IMAS-Core/blob/develop/src/uda/uda_backend.cpp#L874
I would appreciate it if you would review it and let me know if other symbols should be exported.