Skip to content

Pull request review fixes#646

Merged
shimwell merged 9 commits intodevelopfrom
pull_request_review_fixes
Dec 24, 2020
Merged

Pull request review fixes#646
shimwell merged 9 commits intodevelopfrom
pull_request_review_fixes

Conversation

@shimwell
Copy link
Collaborator

Proposed changes

Just couldn't resist fixing a few bugs noticed by the PullRequest review, particularly the ones where tests were not actually running due to the duplicate names.

For each commit is in response to a suggestion in #639

I have added some text to the suggestions (linking the commit to the suggestion) I am addressing so that these suggestions can be resolved once this PR is merged.

What do people think, is this a reasonable way to go about addressing the comments in the PullRequest review?

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@shimwell shimwell changed the base branch from main to develop December 21, 2020 19:27
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #646 (cbf34d8) into develop (fc5a184) will decrease coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #646      +/-   ##
===========================================
- Coverage    98.59%   98.59%   -0.01%     
===========================================
  Files           68       68              
  Lines         4125     4123       -2     
===========================================
- Hits          4067     4065       -2     
  Misses          58       58              
Impacted Files Coverage Δ
paramak/parametric_neutronics/neutronics_model.py 89.80% <33.33%> (ø)
paramak/shape.py 97.71% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f7667...cbf34d8. Read the comment docs.

@shimwell
Copy link
Collaborator Author

I think this is ok to merge, just adding a few recommended fixes

@shimwell shimwell merged commit d699820 into develop Dec 24, 2020
@shimwell shimwell deleted the pull_request_review_fixes branch December 24, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant