Fix port cutting z position#714
Merged
billingsley-john merged 31 commits intodevelopfrom Feb 16, 2021
Merged
Conversation
Collaborator
|
Smaller PRs can be easier to merge in so thanks for this change. I shall take a look soon |
…a/paramak into fix_port_cutting_z_position
RemDelaporteMathurin
requested changes
Feb 4, 2021
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Some really tiny comments :-)
Author
|
Thanks @RemDelaporteMathurin for the suggested changes |
…a/paramak into fix_port_cutting_z_position
…a/paramak into fix_port_cutting_z_position
Codecov Report
@@ Coverage Diff @@
## develop #714 +/- ##
========================================
Coverage 98.87% 98.87%
========================================
Files 68 68
Lines 4337 4352 +15
========================================
+ Hits 4288 4303 +15
Misses 49 49
Continue to review full report at Codecov.
|
Author
|
Think this is ready to merge unless anyone has any suggestions? @RemDelaporteMathurin @shimwell |
10 tasks
…a/paramak into fix_port_cutting_z_position
Author
|
Think this should be ready for merging @shimwell @RemDelaporteMathurin once tests pass |
RemDelaporteMathurin
approved these changes
Feb 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR partially replaces #610 by implementing the z_pos - center_point changes to the port cutters. This PR does NOT add automatic port cutting to reactors (like #610) - this will be done in a separate PR
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...