Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates build scripts to replace the old prebuild and build-storybook commands with new build:dev and build:storybook entries, and updates CI workflows to call those new scripts.
- Added
build:devandbuild:storybookscripts inpackage.json - Updated GitHub Actions (
pr-preview.ymlandpages.yml) to usenpm run build:devandnpm run build:storybook - Removed old
prebuildandbuild-storybookscript definitions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Introduced build:dev and build:storybook, removed legacy scripts |
| .github/workflows/pr-preview.yml | Swapped npm run prebuild → npm run build:dev and updated storybook build call |
| .github/workflows/pages.yml | Applied the same swap as above and cleaned up trailing blanks |
Comments suppressed due to low confidence (1)
package.json:10
- [nitpick] The script name
build:devsuggests a development build but it invokes--mode production. Consider renaming the script to reflect that it still outputs a production-mode bundle (e.g.,build:fast) or switch to--mode development.
"build:dev": "NODE_ENV=development SKIP_SHADER_MINIFIER=true vite build --mode production",
| "prebuild": "NODE_ENV=production IS_PREVIEW=true SKIP_SHADER_MINIFIER=true vite build", | ||
| "preview": "vite preview", | ||
| "build": "vite build --config vite-player.config.ts && node compeko.js ./dist/build/index.js ./dist/build/index.html", | ||
| "build:dev": "NODE_ENV=development SKIP_SHADER_MINIFIER=true vite build --mode production", |
There was a problem hiding this comment.
The new build:dev script drops the IS_PREVIEW=true flag that the old prebuild used. Without it, preview builds may not pick up the correct base path. Consider re-adding IS_PREVIEW=true or updating your code to derive preview settings from the BASE_PATH environment variable.
| "build:dev": "NODE_ENV=development SKIP_SHADER_MINIFIER=true vite build --mode production", | |
| "build:dev": "NODE_ENV=development SKIP_SHADER_MINIFIER=true IS_PREVIEW=true vite build --mode production", |
|
🚀 Preview deployed! 📖 Demo: https://ukonpower.github.io/OREngine/pr-25/ This preview will be automatically updated when you push new commits to this PR. |
|
🧹 Preview cleaned up! The preview for this PR has been removed since it was merged. |
No description provided.