Skip to content

fix devbuild#25

Merged
ukonpower merged 1 commit intomasterfrom
develop
Jun 6, 2025
Merged

fix devbuild#25
ukonpower merged 1 commit intomasterfrom
develop

Conversation

@ukonpower
Copy link
Copy Markdown
Owner

No description provided.

@ukonpower ukonpower requested a review from Copilot June 6, 2025 03:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates build scripts to replace the old prebuild and build-storybook commands with new build:dev and build:storybook entries, and updates CI workflows to call those new scripts.

  • Added build:dev and build:storybook scripts in package.json
  • Updated GitHub Actions (pr-preview.yml and pages.yml) to use npm run build:dev and npm run build:storybook
  • Removed old prebuild and build-storybook script definitions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
package.json Introduced build:dev and build:storybook, removed legacy scripts
.github/workflows/pr-preview.yml Swapped npm run prebuildnpm run build:dev and updated storybook build call
.github/workflows/pages.yml Applied the same swap as above and cleaned up trailing blanks
Comments suppressed due to low confidence (1)

package.json:10

  • [nitpick] The script name build:dev suggests a development build but it invokes --mode production. Consider renaming the script to reflect that it still outputs a production-mode bundle (e.g., build:fast) or switch to --mode development.
"build:dev": "NODE_ENV=development SKIP_SHADER_MINIFIER=true vite build --mode production",

"prebuild": "NODE_ENV=production IS_PREVIEW=true SKIP_SHADER_MINIFIER=true vite build",
"preview": "vite preview",
"build": "vite build --config vite-player.config.ts && node compeko.js ./dist/build/index.js ./dist/build/index.html",
"build:dev": "NODE_ENV=development SKIP_SHADER_MINIFIER=true vite build --mode production",
Copy link

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new build:dev script drops the IS_PREVIEW=true flag that the old prebuild used. Without it, preview builds may not pick up the correct base path. Consider re-adding IS_PREVIEW=true or updating your code to derive preview settings from the BASE_PATH environment variable.

Suggested change
"build:dev": "NODE_ENV=development SKIP_SHADER_MINIFIER=true vite build --mode production",
"build:dev": "NODE_ENV=development SKIP_SHADER_MINIFIER=true IS_PREVIEW=true vite build --mode production",

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2025

🚀 Preview deployed!

📖 Demo: https://ukonpower.github.io/OREngine/pr-25/
📚 Storybook: https://ukonpower.github.io/OREngine/pr-25/storybook/

This preview will be automatically updated when you push new commits to this PR.

@ukonpower ukonpower merged commit 06753d1 into master Jun 6, 2025
5 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2025

🧹 Preview cleaned up!

The preview for this PR has been removed since it was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants