Skip to content

Fix private naming#26

Merged
ukonpower merged 2 commits intodevelopfrom
codex/プライベートメソッドと変数の修正
Jun 6, 2025

Hidden character warning

The head ref may contain hidden characters: "codex/\u30d7\u30e9\u30a4\u30d9\u30fc\u30c8\u30e1\u30bd\u30c3\u30c9\u3068\u5909\u6570\u306e\u4fee\u6b63"
Merged

Fix private naming#26
ukonpower merged 2 commits intodevelopfrom
codex/プライベートメソッドと変数の修正

Conversation

@ukonpower
Copy link
Copy Markdown
Owner

Summary

  • prefix private members with _
  • add getters for updated members

Testing

  • npm test (fails: Failed to load url packages due to env)
  • npm run lint (fails: invalid option '--ext')
  • npx tsc -p tsconfig.json --noEmit (fails: TS6305 output file not built)

https://chatgpt.com/codex/tasks/task_e_68427221391c832a95f7aa2a0446a608

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2025

🚀 Preview deployed!

📖 Demo: https://ukonpower.github.io/OREngine/pr-26/
📚 Storybook: https://ukonpower.github.io/OREngine/pr-26/storybook/

This preview will be automatically updated when you push new commits to this PR.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on June 12, 2025
You have used $0.00 of your $0.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@ukonpower ukonpower merged commit ecd54dd into develop Jun 6, 2025
3 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2025

🧹 Preview cleaned up!

The preview for this PR has been removed since it was merged.

@ukonpower ukonpower deleted the codex/プライベートメソッドと変数の修正 branch June 6, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant