Skip to content

NOISSUE - Enhance OCI image extraction to return algorithm and requirements paths, and add deferred cleanup for temporary files#586

Merged
drasko merged 11 commits intoultravioletrs:mainfrom
SammyOina:complete-oci-pull
Mar 27, 2026
Merged

NOISSUE - Enhance OCI image extraction to return algorithm and requirements paths, and add deferred cleanup for temporary files#586
drasko merged 11 commits intoultravioletrs:mainfrom
SammyOina:complete-oci-pull

Conversation

@SammyOina
Copy link
Copy Markdown
Contributor

@SammyOina SammyOina commented Mar 25, 2026

What type of PR is this?

What does this do?

  • New Features

    • Added support for Docker algorithm format, enabling conversion of container images for execution.
    • Introduced gRPC health check service for improved service monitoring and reliability.
  • Bug Fixes

    • Improved temporary file cleanup during execution to prevent disk space issues.
    • Enhanced algorithm type detection and requirements handling for Python algorithms.
  • Tests

    • Added comprehensive test coverage for Docker algorithm workflows.

Which issue(s) does this PR fix/relate to?

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

image image image

…ts paths, and add deferred cleanup for temporary files.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…on for resources

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…VM server, and refine algorithm argument handling and documentation.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…rithm result saving, `requirements.txt`, and `algo-args` for RVPS.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…r whitespace in tests.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina self-assigned this Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 73.47826% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.87%. Comparing base (42b0552) to head (ed58c89).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
agent/service.go 57.35% 21 Missing and 8 partials ⚠️
internal/zip.go 55.81% 15 Missing and 4 partials ⚠️
agent/algorithm/python/python.go 60.00% 2 Missing and 2 partials ⚠️
agent/runner/service/service.go 33.33% 2 Missing and 2 partials ⚠️
agent/algorithm/wasm/wasm.go 75.00% 1 Missing and 1 partial ⚠️
agent/algorithm/binary/binary.go 87.50% 0 Missing and 1 partial ⚠️
pkg/oci/extract.go 98.18% 1 Missing ⚠️
pkg/oci/skopeo.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
+ Coverage   73.57%   74.87%   +1.29%     
==========================================
  Files          96       96              
  Lines        6123     6244     +121     
==========================================
+ Hits         4505     4675     +170     
+ Misses       1204     1159      -45     
+ Partials      414      410       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… OCI, and agent components.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…gnized data file extensions to include common archive formats.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…datasets, refactor algorithm execution for testability, and enhance algorithm stop and error handling tests.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…an unused mock exec command.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…d OCI resource extraction.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
… handling, and add concurrency safety to agent service.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@drasko drasko merged commit b44780d into ultravioletrs:main Mar 27, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants