Skip to content

NOISSUE - Enforce binding label check#589

Open
danko-miladinovic wants to merge 1 commit intoultravioletrs:mainfrom
danko-miladinovic:satls
Open

NOISSUE - Enforce binding label check#589
danko-miladinovic wants to merge 1 commit intoultravioletrs:mainfrom
danko-miladinovic:satls

Conversation

@danko-miladinovic
Copy link
Copy Markdown
Contributor

What type of PR is this?

This is a bug fix because it enforces ExporterLabelAttestation check on attestation verification.

What does this do?

Enforces the server and the client to use ExporterLabelAttestation during attestation binding process of attested TLS.

Which issue(s) does this PR fix/relate to?

No issue.

Have you included tests for your changes?

Yes, I have included tests for my changes.

Did you document any new/modified feature?

Documentation is not needed.

Notes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.41%. Comparing base (b44780d) to head (9cd6ac2).

Files with missing lines Patch % Lines
pkg/atls/eaattestation/types.go 66.66% 1 Missing and 1 partial ⚠️
pkg/atls/eaattestation/verify.go 75.00% 2 Missing ⚠️
pkg/atls/internal_transport/conn.go 0.00% 1 Missing and 1 partial ⚠️
pkg/atls/ea/cmw_attestation.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   68.36%   68.41%   +0.04%     
==========================================
  Files         116      116              
  Lines        7344     7358      +14     
==========================================
+ Hits         5021     5034      +13     
- Misses       1746     1748       +2     
+ Partials      577      576       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant