Skip to content

Conversation

@acoumb
Copy link
Contributor

@acoumb acoumb commented Nov 17, 2025

Algolia integration upgraded to work with Umbraco 17.

@acoumb acoumb requested a review from Copilot November 17, 2025 09:13
Copilot finished reviewing on behalf of acoumb November 17, 2025 09:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Algolia integration to be compatible with Umbraco 17. The changes include updating the target framework from .NET 9.0 to .NET 10.0, upgrading package dependencies to align with Umbraco 17 requirements (including the Umbraco CMS package version), and updating the frontend dependencies (including TipTap, Monaco Editor, and various Umbraco UI libraries).

Key Changes:

  • Target framework upgraded from net9.0 to net10.0
  • Umbraco CMS package version updated to 17.0.0-rc2
  • Package version bumped from 5.0.1 to 6.0.0
  • Frontend dependencies upgraded to support Umbraco 17
  • Service class renamed from AlgoliaSearchService to AlgoliaSearch

Reviewed Changes

Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Umbraco.Cms.Integrations.Search.Algolia.csproj Updated target framework to net10.0, Umbraco package to 17.0.0-rc2, and version to 6.0.0
algolia-index.repository.ts Refactored to use renamed AlgoliaSearch service class
umbraco-package.json Version bumped to 6.0.0
package.json Updated peer and dev dependencies to Umbraco 17 versions
package-lock.json Updated all dependency versions and resolved peer dependencies
openapi-ts.config.js Changed localhost port from 58030 to 28157
types.gen.ts Updated auto-generated types with new error handling structures
sdk.gen.ts Service class renamed from AlgoliaSearchService to AlgoliaSearch
index.ts Formatting change (whitespace)
client.gen.ts Updated base URL to match new localhost port

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@acoumb acoumb requested a review from Copilot November 17, 2025 09:21
Copilot finished reviewing on behalf of acoumb November 17, 2025 09:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 11 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


<PropertyGroup>
<UmbracoCmsPackageVersion>[16.0.0, 17)</UmbracoCmsPackageVersion>
<UmbracoCmsPackageVersion>[17.0.0-rc2, 18)</UmbracoCmsPackageVersion>
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Umbraco CMS package version constraint uses a pre-release version (17.0.0-rc2). For production releases, it's recommended to use stable versions. If this is intentional for development/testing purposes, consider documenting this or ensuring it's updated before the final release.

Suggested change
<UmbracoCmsPackageVersion>[17.0.0-rc2, 18)</UmbracoCmsPackageVersion>
<UmbracoCmsPackageVersion>[17.0.0, 18)</UmbracoCmsPackageVersion>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants