-
Notifications
You must be signed in to change notification settings - Fork 23
Feature/v17/algolia #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v17/dev
Are you sure you want to change the base?
Feature/v17/algolia #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Algolia integration to be compatible with Umbraco 17. The changes include updating the target framework from .NET 9.0 to .NET 10.0, upgrading package dependencies to align with Umbraco 17 requirements (including the Umbraco CMS package version), and updating the frontend dependencies (including TipTap, Monaco Editor, and various Umbraco UI libraries).
Key Changes:
- Target framework upgraded from net9.0 to net10.0
- Umbraco CMS package version updated to 17.0.0-rc2
- Package version bumped from 5.0.1 to 6.0.0
- Frontend dependencies upgraded to support Umbraco 17
- Service class renamed from
AlgoliaSearchServicetoAlgoliaSearch
Reviewed Changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Umbraco.Cms.Integrations.Search.Algolia.csproj | Updated target framework to net10.0, Umbraco package to 17.0.0-rc2, and version to 6.0.0 |
| algolia-index.repository.ts | Refactored to use renamed AlgoliaSearch service class |
| umbraco-package.json | Version bumped to 6.0.0 |
| package.json | Updated peer and dev dependencies to Umbraco 17 versions |
| package-lock.json | Updated all dependency versions and resolved peer dependencies |
| openapi-ts.config.js | Changed localhost port from 58030 to 28157 |
| types.gen.ts | Updated auto-generated types with new error handling structures |
| sdk.gen.ts | Service class renamed from AlgoliaSearchService to AlgoliaSearch |
| index.ts | Formatting change (whitespace) |
| client.gen.ts | Updated base URL to match new localhost port |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <PropertyGroup> | ||
| <UmbracoCmsPackageVersion>[16.0.0, 17)</UmbracoCmsPackageVersion> | ||
| <UmbracoCmsPackageVersion>[17.0.0-rc2, 18)</UmbracoCmsPackageVersion> |
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Umbraco CMS package version constraint uses a pre-release version (17.0.0-rc2). For production releases, it's recommended to use stable versions. If this is intentional for development/testing purposes, consider documenting this or ensuring it's updated before the final release.
| <UmbracoCmsPackageVersion>[17.0.0-rc2, 18)</UmbracoCmsPackageVersion> | |
| <UmbracoCmsPackageVersion>[17.0.0, 18)</UmbracoCmsPackageVersion> |
Algolia integration upgraded to work with Umbraco 17.