Feature/v17/hubspot #289
Open
Feature/v17/hubspot #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-filtering Bugfix/v16/activecampaign/pagination filtering
Update V16 with changes for load balancing environments and converters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the HubSpot integration to work with Umbraco 17, including dependency updates, refactoring to use a factory pattern for authorization services, and improvements to the ActiveCampaign integration with server-side search functionality.
Key Changes:
- Upgraded target framework from .NET 9.0 to .NET 10.0 for HubSpot integration
- Replaced delegate-based authorization service instantiation with a factory pattern
- Updated frontend dependencies to Umbraco 17.0.0-rc2 and related packages
- Enhanced ActiveCampaign integration with server-side search and pagination
Reviewed Changes
Copilot reviewed 35 out of 41 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Umbraco.Cms.Integrations.Crm.Hubspot.csproj | Updated target framework to net10.0, version to 8.0.0, and Umbraco package version to 17.0.0-rc2 |
| HubspotComposer.cs | Replaced delegate factory with IHubspotAuthorizationServiceFactory registration |
| HubspotAuthorizationServiceFactory.cs | New factory implementation for creating authorization services |
| IHubspotAuthorizationServiceFactory.cs | New factory interface |
| Controllers (GetAccessToken, GetAuthorizationUrl, RefreshAccessToken, ValidateAccessToken) | Updated to use factory instead of delegate |
| Client package files | Updated dependencies to @umbraco-cms/backoffice 17.0.0-rc2, @hey-api packages, and generated types |
| hubspot-forms.repository.ts | Changed service name from FormsService to Forms |
| Property editor elements | Updated type reference from HubspotFormPickerSettingsModelReadable to HubspotFormPickerSettingsModel |
| Algolia integration | Added ContentPublishedHandler and updated media picker converter for single media items |
| ActiveCampaign integration | Added server-side search functionality with query parameter support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+44
to
+53
| foreach (var item in inputMedia) | ||
| { | ||
| if (item == null) continue; | ||
|
|
||
| var mediaItem = _mediaService.GetById(Guid.Parse(item.MediaKey)); | ||
| var mediaItem = _mediaService.GetById(Guid.Parse(item.MediaKey)); | ||
|
|
||
| if (mediaItem == null) continue; | ||
| if (mediaItem == null) continue; | ||
|
|
||
| list.Add(mediaItem.GetValue("umbracoFile")?.ToString() ?? string.Empty); | ||
| list.Add(mediaItem.GetValue("umbracoFile")?.ToString() ?? string.Empty); | ||
| } |
There was a problem hiding this comment.
This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HubSpot integration upgraded to work with Umbraco 17.