Lock-input: update readonly when locked changes #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copilot finished reviewing on behalf of
nielslyngsoe
November 13, 2025 16:50
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the readonly property was not being updated when the locked property changed externally (outside of the button click handler). The fix ensures that the input's readonly state is synchronized with the locked state regardless of how the locked property is changed.
Key Changes:
- Added
this.readonly = lock;to thelockedsetter to ensure readonly is updated when locked changes externally - Removed redundant
this.readonly =assignment from_onLockToggle()method since the setter now handles this update
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1223.westeurope.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input should become readonly when locked, but this is only reflected when changes via the button. externally this is not updated. This pr fixes that.